Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: qa <qa@g.o>, netmon@g.o, comrel@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-libs/libssh2/
Date: Mon, 01 Oct 2018 19:41:30
Message-Id: 1538422879.1095.16.camel@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-libs/libssh2/ by Jeroen Roovers
1 On Mon, 2018-10-01 at 21:30 +0200, Jeroen Roovers wrote:
2 > On Mon, 01 Oct 2018 17:00:24 +0200
3 > Michał Górny <mgorny@g.o> wrote:
4 >
5 > > So your src_compile() is now broken for Ninja users, and src_test()
6 > > is broken altogether. How about cmake-multilib eclass?
7 >
8 > DROP
9 >
10 > > IUSE=test is not used at all.
11 >
12 > THAT
13 >
14 > > By the way, MULTILIB_USEDEP certainly missing here.
15 >
16 > BLOODY
17 >
18 > > You sure this autoconf patch is needed for CMake build?
19 >
20 > AWFUL
21 >
22 > > They must have hacked that CMake hard to get it to generate .la files.
23 >
24 > ATTITUTE
25
26 Then please kindly improve the quality of your Gentoo work. Ebuild
27 writing is more than copying files and doing the minimal change
28 necessary for it not to explode in your face.
29
30 Furthermore, I don't really understand why you're CC-ing netmon@ here.
31 Given you've cut off all the context, my suggestions would seem rather
32 meaningless to the other member.
33
34 --
35 Best regards,
36 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature