Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst
Date: Thu, 15 Aug 2019 07:19:41
Message-Id: w6g7e7elwud.fsf@kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst by Mike Gilbert
>>>>> On Thu, 15 Aug 2019, Mike Gilbert wrote:
> + # Path might be missing due to INSTALL_MASK, etc. > + # https://bugs.gentoo.org/691478 > + if [[ -e "${ED}/${ACCT_USER_HOME#/}" ]]; then > + fowners "${ACCT_USER_HOME_OWNER}" "${ACCT_USER_HOME}" > + fperms "${ACCT_USER_HOME_PERMS}" "${ACCT_USER_HOME}" > + fi
IIUC, this would result in an entry for the directory in /etc/passwd, but the directory wouldn't exist on the system? I don't think that's a sane situation, so maybe the eclass should just die here? (Basically, there are two possibilities: Either, things will break if the dir is missing, then dying might be the best option. Or, everything works without the dir, then the ebuild should set it to /dev/null, in the first place.) Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies