Re: [gentoo-dev] PMS EAPI 3 more or less ready

[Ciaran McCreesh]

This reply's just for minor wording things. If anyone's wanting to
turn any of these into something more substantial, please change the
subject and cut it back to one topic per subthread.

On Tue, 21 Apr 2009 05:11:15 +0300
Mart Raudsepp <leio@g.o> wrote:
> query/yes; but the default src_install maybe shouldn't be doing the
> file exists and is greater than zero check, because dodoc in portage
> already does that. Maybe formalize that and leave that check for dodoc
> responsibility and don't bother checking twice?

I'd rather leave it the way it is; otherwise things get confusing as
dodoc's error handling behaviour gradually gets tightened up over newer
EAPIs.

> query. Lacks specification of what "correct" is in "must correctly
> handle symlinks when installing recursively", so can't judge.

I've tightened up the wording in PMS for that.

> Also, would be interesting to know what sanity checks one would want
> to apply in the future for absolute path symlinks in case they do not
> start with $EPREFIX (don't honor --prefix)? Just curious for the
> future on this one.

There's already special behaviour mandated for merging absolute
symlinks that point to things under $D.

> Additionally the PMS draft has a typo:
>
> newinclude
>         As above, for doexample. Only in EAPIs listed in table 12.7

Fixed, thanks.


> but also what if we want to display information based on saved
> environment? Any suggestion into the spec which way to use for
> checking if the package in question is already installed or not?

has_version works there.

> > * UNPACK-IF-COMPRESSED
>
> query
> I think the spec draft reads that it will be an error to pass regular
> files to unpack --if-compressed. That seems backwards.

Uh, yeah, there's a missing 'not' or 'unless' there. Fixed.

-- 
Ciaran McCreesh