1 |
Dnia 2015-06-24, o godz. 16:04:39 |
2 |
William Hubbs <williamh@g.o> napisał(a): |
3 |
|
4 |
> On Wed, Jun 24, 2015 at 07:02:49PM +0200, Michał Górny wrote: |
5 |
> > Dnia 2015-06-24, o godz. 11:51:44 |
6 |
> > William Hubbs <williamh@g.o> napisał(a): |
7 |
> > |
8 |
> > > On Wed, Jun 24, 2015 at 05:54:31PM +0200, Michał Górny wrote: |
9 |
> > > > Dnia 2015-06-24, o godz. 15:38:34 |
10 |
> > > > "William Hubbs (williamh)" <williamh@g.o> napisał(a): |
11 |
> > > |
12 |
> > > *snip* |
13 |
> > > |
14 |
> > > > > # @FUNCTION: _golang-build_setup |
15 |
> > > > > # @INTERNAL |
16 |
> > > > > # @DESCRIPTION: |
17 |
> > > > > # Make sure EGO_PN has a value. |
18 |
> > > > > _golang-build_setup() { |
19 |
> > > > > [ -z "${EGO_PN}" ] && |
20 |
> > > > |
21 |
> > > > Please don't use 'unsafe' single brackets. Use bash's double brackets, |
22 |
> > > > i.e. [[ -z ${EGO_PN} ]]. |
23 |
> > > |
24 |
> > > Ok, this will be fixed. |
25 |
> > > |
26 |
> > > > > golang-build_src_compile() { |
27 |
> > > > > debug-print-function ${FUNCNAME} "$@" |
28 |
> > > > > |
29 |
> > > > > _golang-build_setup |
30 |
> > > > > set -- env GOPATH="${WORKDIR}/${P}:${EPREFIX}/usr/lib/go-gentoo" \ |
31 |
> > > > > go build -v -work -x "${EGO_PN}" |
32 |
> > > > > echo "$@" |
33 |
> > > > |
34 |
> > > > I suggest to push this to stderr, >&2. |
35 |
> > > |
36 |
> > > Why? this is just printing the command before we run it. Do Make, etc |
37 |
> > > print this output to stderr? |
38 |
> > |
39 |
> > This is pretty much a debugging output which doesn't belong besides |
40 |
> > regular output. Make doesn't, bash does. |
41 |
> |
42 |
> My concern is, if the go tools themselves put some output on stdout and |
43 |
> some on stderr and I redirect everything to stderr, that could break |
44 |
> upstream behaviour, and I would rather not do that. |
45 |
|
46 |
I mean only the echo, not the command itself. |
47 |
|
48 |
-- |
49 |
Best regards, |
50 |
Michał Górny |
51 |
<http://dev.gentoo.org/~mgorny/> |