Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Rolf Eike Beer <eike@×××××××.de>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] qmail.eclass: remove usage of egrep
Date: Sat, 21 May 2022 08:44:49
Message-Id: uh75jjmvg@gentoo.org
In Reply to: [gentoo-dev] [PATCH 2/2] qmail.eclass: remove usage of egrep by Rolf Eike Beer
1 >>>>> On Mon, 16 May 2022, Rolf Eike Beer wrote:
2
3 > This does not use extended regular expressions in any way. While at it change
4 > the way these matches are done: it's irrelevant if the entire expression is in
5 > the file, if there is any rule for the given IP address then do not add the
6 > new
7 > expression.
8
9 Series LGTM. However, "git am" fails for the second patch because the
10 line breaks in your message are messed up:
11
12 Applying: qmail.eclass: remove usage of egrep
13 error: corrupt patch at line 17
14 Patch failed at 0001 qmail.eclass: remove usage of egrep
15
16 (I believe the problem is not on my side, because I see the spurious
17 line breaks also in archives:
18 https://archives.gentoo.org/gentoo-dev/message/b34c3f96f9e4069516b1457e7b0b4904#L32 )

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [PATCH 2/2] qmail.eclass: remove usage of egrep Rolf Eike Beer <eike@×××××××.de>