Gentoo Archives: gentoo-dev

From: Michael Palimaka <kensington@g.o>
To: gentoo-dev@l.g.o
Cc: Michael Palimaka <kensington@g.o>
Subject: [gentoo-dev] [PATCH 06/15] cmake-utils.eclass: ban WANT_CMAKE in EAPI 6 and later
Date: Wed, 20 Jan 2016 10:47:49
Message-Id: 1453286593-26823-7-git-send-email-kensington@gentoo.org
In Reply to: [gentoo-dev] [PATCH 00/15] EAPI 6 support for cmake-utils.eclas by Michael Palimaka
1 It is basically unused across the tree and complicates the eclass. If it were
2 needed, it might be better to write custom ebuild phase functions instead.
3 ---
4 eclass/cmake-utils.eclass | 3 +++
5 1 file changed, 3 insertions(+)
6
7 diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
8 index 28caed2..1de863f 100644
9 --- a/eclass/cmake-utils.eclass
10 +++ b/eclass/cmake-utils.eclass
11 @@ -103,6 +103,8 @@ _CMAKE_UTILS_ECLASS=1
12 # This is useful when only part of application is using cmake build system.
13 # Valid values are: always [default], optional (where the value is the useflag
14 # used for optionality)
15 +#
16 +# This is banned in EAPI 6 and later.
17 : ${WANT_CMAKE:=always}
18
19 # @ECLASS-VARIABLE: CMAKE_EXTRA_CACHE_FILE
20 @@ -125,6 +127,7 @@ case ${WANT_CMAKE} in
21 always)
22 ;;
23 *)
24 + has "${EAPI:-0}" 2 3 4 5 || die "WANT_CMAKE is banned in EAPI 6 and later"
25 IUSE+=" ${WANT_CMAKE}"
26 CMAKEDEPEND+="${WANT_CMAKE}? ( "
27 ;;
28 --
29 2.4.10