Gentoo Archives: gentoo-dev

From: "Marty E. Plummer" <hanetzer@×××××××××.com>
To: gentoo-dev@l.g.o
Cc: Ulrich Mueller <ulm@g.o>
Subject: Re: [gentoo-dev] [PATCH] java-utils-2.eclass: port to EAPI 7
Date: Wed, 23 May 2018 02:34:41
Message-Id: 20180523023359.ganmc2mdbn3rzwj2@proprietary-killer
In Reply to: Re: [gentoo-dev] [PATCH] java-utils-2.eclass: port to EAPI 7 by "Marty E. Plummer"
1 On Mon, May 21, 2018 at 05:13:18PM -0500, Marty E. Plummer wrote:
2 > On Mon, May 21, 2018 at 04:47:03PM -0500, Marty E. Plummer wrote:
3 > > On Tue, May 08, 2018 at 11:03:47AM +0200, Ulrich Mueller wrote:
4 > > > You could inherit eapi7-ver instead of versionator, which would save
5 > > > the conditional below.
6 > > >
7 > > I didn't realize that eapi7-ver now supports 0-6 instead of just 6. I
8 > > will rework this and the other patch I sent in for that reason, then.
9 > Here we go. The eapi != 7 conditional is needed as eapi7 is 'not
10 > supported' by eapi7-ver because its contents are already there.
11
12 Once more, with changes suggested by [Arfrever] in #gentoo-java.
13 ---
14 eclass/java-utils-2.eclass | 7 ++++---
15 1 file changed, 4 insertions(+), 3 deletions(-)
16
17 diff --git a/eclass/java-utils-2.eclass b/eclass/java-utils-2.eclass
18 index 25e35c33dd2..f45b29c9e32 100644
19 --- a/eclass/java-utils-2.eclass
20 +++ b/eclass/java-utils-2.eclass
21 @@ -15,7 +15,8 @@
22 # you should inherit java-pkg-2 for Java packages or java-pkg-opt-2 for packages
23 # that have optional Java support. In addition you can inherit java-ant-2 for
24 # Ant-based packages.
25 -inherit eutils versionator multilib
26 +[[ ${EAPI:-0} == [012345] ]] && inherit multilib
27 +[[ ${EAPI:-0} == [0123456] ]] && inherit eapi7-ver eutils
28
29 IUSE="elibc_FreeBSD"
30
31 @@ -1526,8 +1527,8 @@ java-pkg_is-vm-version-eq() {
32
33 local vm_version="$(java-pkg_get-vm-version)"
34
35 - vm_version="$(get_version_component_range 1-2 "${vm_version}")"
36 - needed_version="$(get_version_component_range 1-2 "${needed_version}")"
37 + vm_version="$(ver_cut 1-2 "${vm_version}")"
38 + needed_version="$(ver_cut 1-2 "${needed_version}")"
39
40 if [[ -z "${vm_version}" ]]; then
41 debug-print "Could not get JDK version from DEPEND"
42 --
43 2.17.0

Replies

Subject Author
Re: [gentoo-dev] [PATCH] java-utils-2.eclass: port to EAPI 7 "Marty E. Plummer" <hanetzer@×××××××××.com>