Gentoo Archives: gentoo-dev

From: "Amadeusz Żołnowski" <aidecoe@×××××××.name>
To: Mike Frysinger <vapier@g.o>
Cc: gentoo-dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild
Date: Wed, 13 Oct 2010 22:14:29
Message-Id: 1287006762-sup-7540@etiriah
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild by Mike Frysinger
1 Excerpts from Mike Frysinger's message of Wed Oct 13 23:46:43 +0200 2010:
2 > On Wednesday, October 13, 2010 15:57:17 Amadeusz Żołnowski wrote:
3 > > And why putting different tasks into one function?
4 >
5 > for the same reason we dont have separate test binaries: test_exist,
6 > test_file, test_dir, etc...
7 >
8 > it makes more sense in my mind to combine the functionality.
9 > -mike
10
11 So the only argument for having more complicated, less intuitive and
12 less readable function is the old 'test' program? Please, reconsider my
13 solution with more reason. Moreover we're using 'test' as '[[ … ]]'
14 which changes much in readability. Next thing is that '-a' and '-o'
15 don't strictly conform to 'test' convention.
16 --
17 Amadeusz Żołnowski
18
19 PGP key fpr: C700 CEDE 0C18 212E 49DA 4653 F013 4531 E1DB FAB5

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies