Gentoo Archives: gentoo-dev

From: Samuli Suominen <ssuominen@g.o>
To: gentoo-dev@l.g.o, jlec@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild
Date: Fri, 03 May 2013 17:58:34
Message-Id: 5183FAB9.4010901@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild by Samuli Suominen
1 On 03/05/13 20:56, Samuli Suominen wrote:
2 > On 03/05/13 20:33, Justin Lecher (jlec) wrote:
3 >> jlec 13/05/03 17:33:56
4 >>
5 >> Modified: metadata.xml ChangeLog
6 >> Added: id3lib-3.8.3-r9.ebuild
7 >> Log:
8 >> media-libs/id3lib: Fix obsolete macros to work with automake-1.13,
9 >> #467704; bumped to EAPI=5 and autotools-utils.eclass
10 >>
11 >> (Portage version: 2.2.0_alpha173/cvs/Linux x86_64, signed Manifest
12 >> commit with key 8009D6F070EB7916)
13 >>
14 >> Revision Changes Path
15 >> 1.3 media-libs/id3lib/metadata.xml
16 >>
17 >> file :
18 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&view=markup
19 >>
20 >> plain:
21 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&content-type=text/plain
22 >>
23 >> diff :
24 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?r1=1.2&r2=1.3
25 >>
26 >>
27 >> Index: metadata.xml
28 >> ===================================================================
29 >> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/metadata.xml,v
30 >> retrieving revision 1.2
31 >> retrieving revision 1.3
32 >> diff -u -r1.2 -r1.3
33 >> --- metadata.xml 16 Jul 2009 19:18:11 -0000 1.2
34 >> +++ metadata.xml 3 May 2013 17:33:56 -0000 1.3
35 >> @@ -1,5 +1,5 @@
36 >> <?xml version="1.0" encoding="UTF-8"?>
37 >> <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
38 >> <pkgmetadata>
39 >> - <herd>sound</herd>
40 >> + <herd>sound</herd>
41 >> </pkgmetadata>
42 >
43 > What's the point of kludging unrelated commits like this one...?
44 >
45 >>
46 >>
47 >>
48 >> 1.81 media-libs/id3lib/ChangeLog
49 >>
50 >> file :
51 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&view=markup
52 >>
53 >> plain:
54 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&content-type=text/plain
55 >>
56 >> diff :
57 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?r1=1.80&r2=1.81
58 >>
59 >>
60 >> Index: ChangeLog
61 >> ===================================================================
62 >> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v
63 >> retrieving revision 1.80
64 >> retrieving revision 1.81
65 >> diff -u -r1.80 -r1.81
66 >> --- ChangeLog 22 Mar 2012 12:33:36 -0000 1.80
67 >> +++ ChangeLog 3 May 2013 17:33:56 -0000 1.81
68 >> @@ -1,6 +1,13 @@
69 >> # ChangeLog for media-libs/id3lib
70 >> -# Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
71 >> -# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.80
72 >> 2012/03/22 12:33:36 ssuominen Exp $
73 >> +# Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
74 >> +# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.81
75 >> 2013/05/03 17:33:56 jlec Exp $
76 >> +
77 >> +*id3lib-3.8.3-r9 (03 May 2013)
78 >> +
79 >> + 03 May 2013; Justin Lecher <jlec@g.o> +id3lib-3.8.3-r9.ebuild,
80 >> + metadata.xml:
81 >> + Fix obsolete macros to work with automake-1.13, #467704; bumped to
82 >> EAPI=5 and
83 >> + autotools-utils.eclass
84 >
85 > There was no reason to use autotools-utils.eclass in the ebuild.
86 > Please don't spread the problem in media libraries, you are not even in
87 > the sound team.
88 >
89
90 Heck, with AUTOTOOLS_IN_SOURCE_BUILD=1 it's completely useless.