[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/mplayer: ChangeLog mplayer-1.0_rc1_p20070927.ebuild

[Donnie Berkholz]

On 15:35 Thu 27 Sep     , Steve Dibb (beandog) wrote:
> beandog     07/09/27 15:35:24
>
>   Modified:             ChangeLog
>   Added:                mplayer-1.0_rc1_p20070927.ebuild
>   Log:
>   Subversion bump, install a52 by default with dvd use flag, switch xvmc linking back to generic lib
>   (Portage version: 2.1.3.9)

> 1.1                  media-video/mplayer/mplayer-1.0_rc1_p20070927.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/mplayer/mplayer-1.0_rc1_p20070927.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/mplayer/mplayer-1.0_rc1_p20070927.ebuild?rev=1.1&content-type=text/plain

> 	# DVB / Video4Linux / Radio support
> 	if ( use dvb || use v4l || use v4l2 || use radio ); then

There's no reason to use a subshell here.

> 		if ( use dvb || use v4l || use v4l2 ) && use radio; then

Same here, although I might switch the logic around so 'use radio' is 
first.

> 	if [ -e /dev/.devfsd ]; then

Dependence on the build system is bad.

> 	echo "${myconf}" > ${T}/configure-options

Quotes on T.

> 	make prefix=${D}/usr \
> 		 BINDIR=${D}/usr/bin \
> 		 LIBDIR=${D}/usr/$(get_libdir) \
> 		 CONFDIR=${D}/etc/mplayer \
> 		 DATADIR=${D}/usr/share/mplayer \
> 		 MANDIR=${D}/usr/share/man \
> 		 install || die "Failed to install MPlayer!"

emake broken here? Also needs quotes on D.

> 	if [ -d ${ROOT}/usr/share/mplayer/Skin/default ]

This needs quotes or double brackets.

> 	if [ -L ${ROOT}/usr/share/mplayer/font -a \
> 		 ! -e ${ROOT}/usr/share/mplayer/font ]
> 	then
> 		rm -f ${ROOT}/usr/share/mplayer/font
> 	fi
>
> 	if [ -L ${ROOT}/usr/share/mplayer/subfont.ttf -a \
> 		 ! -e ${ROOT}/usr/share/mplayer/subfont.ttf ]
> 	then
> 		rm -f ${ROOT}/usr/share/mplayer/subfont.ttf

Quotes here too.

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list