1 |
On Tue, 2023-02-28 at 19:03 +0000, Sam James wrote: |
2 |
> Autoconf has a builtin check to try figure out how to make the compiler |
3 |
> error out on implicit function declarations. This check necessarily emits |
4 |
> such a warning/error. We know that -Werror=implicit-function-declaration |
5 |
> will work on any compiler we care about, so just force that to avoid noise. |
6 |
> |
7 |
> This means we don't have to try whitelist 'strchr'. |
8 |
> |
9 |
> v2: drop 'export' as PMS doesn't allow it in make.defaults. |
10 |
> |
11 |
> Signed-off-by: Sam James <sam@g.o> |
12 |
> --- |
13 |
> profiles/base/make.defaults | 6 ++++++ |
14 |
> 1 file changed, 6 insertions(+) |
15 |
> |
16 |
> diff --git a/profiles/base/make.defaults b/profiles/base/make.defaults |
17 |
> index ab69dbfae58ee..68ff36a90cc8d 100644 |
18 |
> --- a/profiles/base/make.defaults |
19 |
> +++ b/profiles/base/make.defaults |
20 |
> @@ -181,3 +181,9 @@ ADA_TARGET="gnat_2021" |
21 |
> # Default targets for lua{,-single}.eclass |
22 |
> LUA_SINGLE_TARGET="lua5-1" |
23 |
> LUA_TARGETS="lua5-1" |
24 |
> + |
25 |
> +# Sam James <sam@g.o> (2023-02-28) |
26 |
> +# Reduce -Wimplicit-function-declaration noise from autoconf. Any compilers |
27 |
> +# we care about should match these anyway. See https://wiki.gentoo.org/wiki/Modern_C_porting. |
28 |
> +ac_cv_c_undeclared_builtin_options="none needed" |
29 |
> +gl_cv_compiler_check_decl_option="-Werror=implicit-function-declaration" |
30 |
|
31 |
LGTM. Thanks! |
32 |
|
33 |
-- |
34 |
Best regards, |
35 |
Michał Górny |