| 1 |
>>>>> On Sun, 5 Oct 2008, Robert Buchholz wrote: |
| 2 |
|
| 3 |
>> So if the ebuild includes non-existing files in DOCS, then why would |
| 4 |
>> you want to suppress the warnings? |
| 5 |
|
| 6 |
> I don't. My point was that the default action on an empty DOCS |
| 7 |
> variable is to "dodoc AUTHORS ChangeLog NEWS README", and this |
| 8 |
> should not emit warnings, because it is merely a heuristic. |
| 9 |
|
| 10 |
> To be clearer: |
| 11 |
> else |
| 12 |
> - # No die here because we don't know if any of these exist |
| 13 |
> - dodoc AUTHORS ChangeLog NEWS README |
| 14 |
> + for x in AUTHORS ChangeLog NEWS README; do |
| 15 |
> + if [ -e ${x} ]; then |
| 16 |
> + dodoc ${x} || die "dodoc ${x} failed" |
| 17 |
> + fi |
| 18 |
> + done |
| 19 |
> fi |
| 20 |
|
| 21 |
I agree. You (and Petteri) are absolutely right. |
| 22 |
|
| 23 |
Ulrich |
Archives