| 1 |
>>>>> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote: |
| 2 |
|
| 3 |
> -# @SUPPORTED_EAPIS: 4 5 6 7 |
| 4 |
> +# @SUPPORTED_EAPIS: 5 6 7 |
| 5 |
|
| 6 |
Support EAPI 8 while at it? AFAICS it's a trivial update. |
| 7 |
|
| 8 |
> case ${EAPI:-0} in |
| 9 |
|
| 10 |
Just ${EAPI} here. |
| 11 |
|
| 12 |
> - 4|5|6) ;; |
| 13 |
> + 5|6) ;; |
| 14 |
> 7) BDEPEND="${DEPEND}"; DEPEND="" ;; |
| 15 |
> *) die "${ECLASS}: EAPI ${EAPI:-0} is not supported" ;; |
| 16 |
> esac |
| 17 |
|
| 18 |
> @@ -483,6 +478,12 @@ cvs_src_unpack() { |
| 19 |
> |
| 20 |
> [[ -z ${ECVS_MODULE} ]] && die "ERROR: CVS module not set, cannot continue." |
| 21 |
> |
| 22 |
> + #default to ssh |
| 23 |
> + [[ -z ${CVS_RSH} ]] && export CVS_RSH="ssh" |
| 24 |
> + if [[ ${CVS_RSH} != "ssh" ]] ; then |
| 25 |
> + die "Support for ext auth with clients other than ssh has not been implemented yet" |
| 26 |
> + fi |
| 27 |
|
| 28 |
That's a strange logic (not your fault, it was like this before). |
| 29 |
So CVS_RSH is taken from the user's environment? Why would one do that? |
| 30 |
Also, if the user has (e.g.) CVS_RSH="/usr/bin/ssh" then the eclass will |
| 31 |
fail? |
| 32 |
|
| 33 |
Can we kill this with fire, please? :) Just use ssh always. |
| 34 |
|
| 35 |
Ulrich |
Archives