Re: [gentoo-dev] [PATCH] gnome2-utils: Drop EAPI < 5 support

[Ulrich Mueller]

>>>>> On Sun, 06 Dec 2020, Matt Turner wrote:

> -[[ ${EAPI:-0} == [012345] ]] && inherit multilib
> +[[ ${EAPI:-0} == [5] ]] && inherit multilib

Useless brackets. Also you could drop the :-0 here.

>  case "${EAPI:-0}" in

No quotes needed here.

> -	0|1|2|3|4|5|6|7) ;;
> -	*) die "EAPI=${EAPI} is not supported" ;;
> +	5|6|7) ;;
> +	0|1|2|3|4) die "EAPI=${EAPI} is not supported" ;;
>  esac

This should have a * instead of an explicit list of unknown EAPIs.
 
>  case ${EAPI:-0} in
> -0|1|2|3|4|5|6)
> +5|6)
 
See above, :-0 could be dropped.

Ulrich