Gentoo Archives: gentoo-dev

From: Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] FEATURES use or misuse?
Date: Tue, 03 Nov 2009 22:26:33
Message-Id: 20091103222624.19d4b591@snowcone
In Reply to: Re: [gentoo-dev] FEATURES use or misuse? by Patrick Lauer
On Tue, 3 Nov 2009 23:04:58 +0100
Patrick Lauer <patrick@g.o> wrote:
> > If you want to fix PMS, then send a patch > I tried, and as I've been saying for a long time they get rejected.
Yes, let's look at the patches that you sent that were rejected: The first was one where you asked the PMS team to make a change that goes directly against a Council decision, and that the PMS team does not have the authority to accept on its own. You were told to bring the issue to gentoo-dev@ for further attention. You never did. The second patch you sent: * incorrectly removed as "no content" two sentences that had specific and necessary meaning. * didn't apply against any version of PMS except your much-modified local version, and that didn't make sense when applied to version of PMS that anyone else had. Again, no updated patch was sent. The third patch you sent had a number of small issues and could have been improved. You did not send an updated patch with those issues fixed.
> Funnily not by any dev but by some random user, but who cares :)
Everyone on the PMS mailing list is more than welcome to do patch reviews. The more eyes we have looking at things the better. Policy is not to apply patches until everyone is happy with them; objections are considered on their merits, not on their author. Every other person who has had people comment upon a patch they submitted has either addressed the issues and submitted an updated patch, or explained why they feel the patch is correct as-is. Every other person who has submitted a patch has worked with all the reviewers to reach a conclusion that is acceptable to all involved. Every other person has an ultimate patch acceptance rate of at least 98%. You are the *only* person to have had patches rejected where the submitter did not agree with the rejection. -- Ciaran McCreesh


File name MIME type
signature.asc application/pgp-signature