Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH] eutils.eclass: Deprecate validate_desktop_entries
Date: Sat, 11 Mar 2017 13:06:32
Message-Id: 20170311130613.29228-1-mgorny@gentoo.org
1 The validate_desktop_entries function is redundant to the built-in
2 .desktop file checks done by Portage directly. It is used in total by
3 two packages for both of which bugs have been filed.
4 ---
5 eclass/eutils.eclass | 3 +++
6 1 file changed, 3 insertions(+)
7
8 diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
9 index e398aafc464a..d91245495caa 100644
10 --- a/eclass/eutils.eclass
11 +++ b/eclass/eutils.eclass
12 @@ -883,6 +883,9 @@ _eutils_eprefix_init() {
13 # @DESCRIPTION:
14 # Validate desktop entries using desktop-file-utils
15 validate_desktop_entries() {
16 + eqawarn "validate_desktop_entries is deprecated and should be not be used."
17 + eqawarn ".desktop file validation is done implicitly by Portage now."
18 +
19 _eutils_eprefix_init
20 if [[ -x "${EPREFIX}"/usr/bin/desktop-file-validate ]] ; then
21 einfo "Checking desktop entry validity"
22 --
23 2.12.0

Replies