| 1 |
> On Apr 17, 2016, at 10:45 AM, Mike Gilbert <floppym@g.o> wrote: |
| 2 |
> |
| 3 |
>> On Sun, Apr 17, 2016 at 10:31 AM, Ian Stakenvicius <axs@g.o> wrote: |
| 4 |
>> |
| 5 |
>> |
| 6 |
>> Sent from an iPhone, sorry for the HTML... |
| 7 |
>> |
| 8 |
>>> On Apr 17, 2016, at 10:13 AM, Mike Gilbert <floppym@g.o> wrote: |
| 9 |
>>> |
| 10 |
>>> @@ -487,10 +497,17 @@ xorg-2_src_configure() { |
| 11 |
>>> xorg-2_src_compile() { |
| 12 |
>>> debug-print-function ${FUNCNAME} "$@" |
| 13 |
>>> |
| 14 |
>>> + local makeargs=( "$@" ) |
| 15 |
>>> + |
| 16 |
>>> if [[ ${XORG_MULTILIB} == yes ]]; then |
| 17 |
>>> - autotools-multilib_src_compile "$@" |
| 18 |
>>> + if ! declare -f multilib_src_compile >/dev/null; then |
| 19 |
>>> + multilib_src_compile() { |
| 20 |
>>> + emake "${makeargs[@]}" |
| 21 |
>>> + } |
| 22 |
>>> + fi |
| 23 |
>>> + multilib-minimal_src_compile |
| 24 |
>>> else |
| 25 |
>>> - autotools-utils_src_compile "$@" |
| 26 |
>>> + emake "${makeargs[@]}" |
| 27 |
>>> fi |
| 28 |
>>> } |
| 29 |
>> |
| 30 |
>> Does the src_compile code need to be as complex as this? Why not just a 'if $XORG_MULTILIB ; then multilib-minimal_src_compile "$@"; else emake "$@"; fi '? |
| 31 |
>> |
| 32 |
>> ...or even 'default' instead of emake...? |
| 33 |
> |
| 34 |
> multilib-mininmal_src_compile and default_src_comple do not provide |
| 35 |
> any method to pass arguments to emake. If I recall correctly, there is |
| 36 |
> at least one ebuild that needs to do so. |
| 37 |
> |
| 38 |
|
| 39 |
That would do it then... |
| 40 |
|
| 41 |
mgorny how difficult do you think it would be to pass extra "$@" bits through to the default multilib_src_compile? Or does that just call 'default' too... (can't check right now) |
Archives