| 1 |
>>>>> On Mon, 5 May 2014, Michał Górny wrote: |
| 2 |
|
| 3 |
> Three quick patches for review: |
| 4 |
|
| 5 |
> 1. adds multilib_get_enabled_abi_pairs() as a replacement for |
| 6 |
> multilib_get_enabled_abis(). The latter returned just the value |
| 7 |
> of ${ABI}, the new function returns ${use_flag}:${ABI} pairs. |
| 8 |
|
| 9 |
> e.g.: |
| 10 |
|
| 11 |
> multilib_get_enabled_abis: x86 amd64 |
| 12 |
> multilib_get_enabled_abi_pairs: abi_x86_32:x86 abi_x86_64:amd64 |
| 13 |
|
| 14 |
These will get included in the pathname of the build dir, right? |
| 15 |
|
| 16 |
If yes, are you sure that all upstream build systems can cope with |
| 17 |
the colon in path names? I'd rather suggest to stay within the POSIX |
| 18 |
portable filename character set (i.e. [A-Za-z0-9._-]). |
| 19 |
|
| 20 |
Ulrich |
Archives