Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7
Date: Tue, 05 Feb 2019 10:21:49
Message-Id: 20190205112137.1aaeb9ba@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7 by Georgy Yakovlev
1 On Mon, 04 Feb 2019 13:42:21 -0800
2 Georgy Yakovlev <gyakovlev@g.o> wrote:
3
4 > On Monday, February 4, 2019 2:52:37 AM PST Alexis Ballier wrote:
5 > > On Sat, 2 Feb 2019 21:27:29 -0800
6 > >
7 > > Georgy Yakovlev <gyakovlev@g.o> wrote:
8 > > > Since D, ED, ROOT, EROOT no longer have a trailing slash in EAPI=7
9 > > > This eclass is terribly broken, installing things into
10 > > > imageusr/...
11 > >
12 > > You might want to check https://github.com/aballier/ml-overlay
13 > Hi!
14 >
15 > I don't really use this eclass in any way.
16 > A user reported breakage, I wrote a patch and submitted here for
17 > review.
18 >
19 > there is a commit in overlay that adds slashes, but paths will end up
20 > having
21 >
22 > // two slashes on EAPI6 and single on EAPI7
23 >
24 > https://github.com/aballier/ml-overlay/commit/
25 > 98c0f16bc490349f17afdd7a7675b9b5264d267e
26 >
27 > also probably the docdir subdir part of opam_src_install() will also
28 > fail, as there are no slashes.
29 >
30 >
31 > ::gentoo version needs some kind of fix as any EAPI7 ebuild that uses
32 > opam.eclass is broken.
33 >
34 > If you are ok with my patches I can commit, just let me know.
35
36
37 yes go ahead (modulo list comments ofc =)