Gentoo Archives: gentoo-dev

From: "Bo Ørsted Andresen" <bo.andresen@××××.dk>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild
Date: Mon, 24 Sep 2007 20:42:38
Message-Id: 200709242228.48630.bo.andresen@zlin.dk
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild by Donnie Berkholz
1 On Monday 24 September 2007 21:56:49 Donnie Berkholz wrote:
2 > > if [[ "$(gcc-major-version)" -gt "3" ]] || \
3 > > ( [[ "$(gcc-major-version)" -eq "3" ]] && [[ "$(gcc-minor-version)" -gt "3" ]] )
4 >
5 > Code block { } might be good here instead of a subshell, or perhaps it
6 > could use logic that's less convoluted such as if..then. Also don't need
7 > the double quotes.
8
9 Or it could be as simple as:
10
11 if [[ $(gcc-major-version) -gt 3 || \
12 ( $(gcc-major-version) -eq 3 && $(gcc-minor-version) -gt 3 ) ]]
13
14 [[ allows grouping of conditions without spawning subshells.
15
16 --
17 Bo Andresen

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies