Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/libiodbc: libiodbc-3.52.7-r1.ebuild ChangeLog

[Samuli Suominen]

On 02/20/2012 09:36 PM, Pacho Ramos wrote:
> El lun, 20-02-2012 a las 17:57 +0200, Samuli Suominen escribió:
>> On 02/20/2012 05:57 PM, Tomas Chvatal (scarabeus) wrote:
>>> scarabeus    12/02/20 15:57:31
>>>
>>>     Modified:             libiodbc-3.52.7-r1.ebuild ChangeLog
>>>     Log:
>>>     Use single thread build as it is broken in paralel on some machines wrt bug#405029.
>>>
>>>     (Portage version: 2.2.0_alpha87/cvs/Linux x86_64)
>>>
>>> Revision  Changes    Path
>>> 1.2                  dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild
>>>
>>> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild?rev=1.2&view=markup
>>> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild?rev=1.2&content-type=text/plain
>>> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild?r1=1.1&r2=1.2
>>>
>>> Index: libiodbc-3.52.7-r1.ebuild
>>> ===================================================================
>>> RCS file: /var/cvsroot/gentoo-x86/dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild,v
>>> retrieving revision 1.1
>>> retrieving revision 1.2
>>> diff -u -r1.1 -r1.2
>>> --- libiodbc-3.52.7-r1.ebuild	20 Feb 2012 10:21:59 -0000	1.1
>>> +++ libiodbc-3.52.7-r1.ebuild	20 Feb 2012 15:57:31 -0000	1.2
>>> @@ -1,6 +1,6 @@
>>>    # Copyright 1999-2012 Gentoo Foundation
>>>    # Distributed under the terms of the GNU General Public License v2
>>> -# $Header: /var/cvsroot/gentoo-x86/dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild,v 1.1 2012/02/20 10:21:59 scarabeus Exp $
>>> +# $Header: /var/cvsroot/gentoo-x86/dev-db/libiodbc/libiodbc-3.52.7-r1.ebuild,v 1.2 2012/02/20 15:57:31 scarabeus Exp $
>>>
>>>    EAPI=4
>>>
>>> @@ -22,6 +22,8 @@
>>>
>>>    DOCS="AUTHORS ChangeLog NEWS README"
>>>
>>> +MAKEOPTS="-j1"
>>> +
>>
>> Why not use MAKEOPTS="${MAKEOPTS} -j1" to allow other make flags get
>> respected?
>>
>>
> About this, I would also like to know if we are allowed to use "MAKEOPTS
> +=..." (and the same for other variables in ebuild) instead or it should
> be avoided for some reason.
>
> Thanks for the info :)
>

+= wasn't allowed because it isn't compatible with bash-3.1 (and 
earlier) if I remember correctly

but that ship has long sailed and += syntax is used all over the tree 
(and by the package manager itself!)

so feel free :)

- Samuli