Gentoo Archives: gentoo-dev

From: Mart Raudsepp <leio@g.o>
To: gentoo-dev@l.g.o
Cc: gnome@g.o
Subject: Re: [gentoo-dev] [PATCH 1/7] gnome2-utils.eclass: Make gnome2_icon_cache_update update all themes
Date: Mon, 17 Apr 2017 13:32:19
Message-Id: 1492435924.9279.1.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 1/7] gnome2-utils.eclass: Make gnome2_icon_cache_update update all themes by Gilles Dartiguelongue
1 Ühel kenal päeval, E, 17.04.2017 kell 13:43, kirjutas Gilles
2 Dartiguelongue:
3 > Le lundi 17 avril 2017 à 13:07 +0200, Michał Górny a écrit :
4 > > Make the gnome2_icon_cache_update function update all icon themes
5 > > rather
6 > > than depending on gnome2_icon_savelist to select themes to update.
7 > > This
8 > > makes the function easier to use whenever the developer needs it
9 > > explicitly (i.e. knows that themes are installed), while the
10 > > overhead
11 > > of
12 > > regenerating multiple caches is neglible.
13 >
14 > Looks good.
15
16 I haven't looked at this yet, but it would be nice if a bunch of
17 gnome2.eclass and gnome2-utils.eclass would be pushed at once after
18 review for cache regeneration purposes. But of course not as important
19 as eutils was, but still hundreds - with gnome2-utils maybe a thousand.
20
21 Potential bugs that might end up needing an eclass change are at least
22 the following (might be more):
23 https://bugs.gentoo.org/615144
24 https://bugs.gentoo.org/613364
25 https://bugs.gentoo.org/show_bug.cgi?id=gnome2.eclass tracker
26
27
28 Mart