1 |
Doug Goldstein wrote: |
2 |
> While the rule of thumb has been if an eclass needs something it should |
3 |
> provide it's own depends. However the virtualx eclass needs to be |
4 |
> different simply because in some cases it's only uses for tests (this is |
5 |
> it's most common usage in the whole) tree. When it's used for tests |
6 |
> pulling in the xorg-server the most ideal situation would be if |
7 |
> xorg-server was only pulled in on USE=test because currently for anyone |
8 |
> emerging an app that uses GTK+ they have a weird situation in the fact |
9 |
> that all of GTK+'s depends that have USE=X use it to mean libX11 (as do |
10 |
> most usages of the X USE flag), however GTK+ itself due to it's usage of |
11 |
> the virtualx eclass pulls in xorg-server when USE=X, which is only used |
12 |
> for tests. This results in a confusing experience for users looking to |
13 |
> built a headless machine. |
14 |
> |
15 |
> It'd be a lot more consistent if ebuilds provided a USE flag or directly |
16 |
> depended on the xorg-server and then used the functions in the eclass. |
17 |
> So in summary, those are the changes I plan on making very shortly. If |
18 |
> someone's got some input, please speak up. |
19 |
> |
20 |
> |
21 |
Dave Leverton brings up a better suggestion. Providing VIRTUALX_DEPS and |
22 |
having the ebuild just toss that into it's depends as needed. |