Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: gentoo-dev@l.g.o
Cc: "Marty E. Plummer" <hanetzer@×××××××××.com>
Subject: Re: [gentoo-dev] [PATCH 1/2] gnome2-utils.eclass: make EAPI 7 ready
Date: Mon, 18 Jun 2018 06:02:16
Message-Id: 23335.19155.867360.388262@a1i15.kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH 1/2] gnome2-utils.eclass: make EAPI 7 ready by "Marty E. Plummer"
1 >>>>> On Sun, 17 Jun 2018, Marty E Plummer wrote:
2
3 > Signed-off-by: Marty E. Plummer <hanetzer@×××××××××.com>
4
5 Please don't yet use Signed-off-by. Our policy on this (GLEP 76) is
6 still a draft and subject to change.
7
8 > -DEPEND=">=sys-apps/sed-4"
9 > -
10 > +# sed needs to be executable on the build system
11 > +BDEPEND=">=sys-apps/sed-4"
12 > +[[ ${EAPI:-0} == [0123456] ]] && DEPEND="${BDEPEND}"
13
14 These >=sed-4 dependencies are a relic from the time when there was a
15 sed-3. It left the tree in 2003 though.
16
17 So I suggest to remove this build-time dependency altogether.
18
19 Ulrich

Replies