Gentoo Archives: gentoo-dev

From: Rolf Eike Beer <eike@×××××××.de>
To: gentoo-dev@l.g.o, Sam James <sam@g.o>
Cc: qa@g.o, base-system@g.o
Subject: Re: [gentoo-dev] [PATCH v2 4/5] qmail.eclass: egrep -> grep -E
Date: Sun, 15 May 2022 15:18:54
Message-Id: 3170986.aeNJFYEL58@daneel.sf-tec.de
In Reply to: [gentoo-dev] [PATCH v2 4/5] qmail.eclass: egrep -> grep -E by Sam James
1 Am Sonntag, 15. Mai 2022, 03:08:41 CEST schrieb Sam James:
2 > Signed-off-by: Sam James <sam@g.o>
3 > ---
4 > eclass/qmail.eclass | 2 +-
5 > 1 file changed, 1 insertion(+), 1 deletion(-)
6 >
7 > diff --git a/eclass/qmail.eclass b/eclass/qmail.eclass
8 > index 471f2fe7ce5e..707cc91adfd8 100644
9 > --- a/eclass/qmail.eclass
10 > +++ b/eclass/qmail.eclass
11 > @@ -452,7 +452,7 @@ qmail_tcprules_config() {
12 > line="${ip}${tcpstring}"
13 > for proto in smtp qmtp qmqp; do
14 > f="${EROOT}${TCPRULES_DIR}/tcp.qmail-${proto}"
15 > - egrep -qs "${line}" "${f}" || echo "${line}" >> "${f}"
16 > + grep -E -qs "${line}" "${f}" || echo "${line}" >> "${f}"
17 > done
18 > done
19 > }
20
21 NACK, but for the simple reason that this doesn't need the extended syntax
22 at all. Just drop it and use plain grep here.
23
24 Eike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [PATCH v2 4/5] qmail.eclass: egrep -> grep -E "Michał Górny" <mgorny@g.o>