Re: [gentoo-dev] [RFC] sword-module.eclass: update, extend, increment revision

[Michał Górny]

On Sun, 2020-07-26 at 14:02 +0200, Marek Szuba wrote:
> Dear all,
>
> sword-module.eclass needs some changes, not in the least because it
> assumes versioned source files are uploaded directly to the Gentoo
> mirror network. The complete list of proposed changes is as follows:
>
>  - add eclassdoc blocks;
>  - add the optional variable SWORD_MINIMUM_VERSION to specify the lowest
> version of app-text/sword supported by the module at hand;
>  - check if SWORD_MODULE is set and not null, and die otherwise;
>  - change the default SRC_URI from mirror://gentoo to my Web space on
> dev.gentoo.org;
>  - remove redundant declarations of HOMEPAGE and IUSE;
>  - app-arch/unzip is now in BDEPEND rather than DEPEND;
>  - as a consequence of the above, enforce the use of EAPI-7 in ebuilds
> inheriting this eclass;
>  - remove redundant references to ${S} from doins() calls.
>
> A diff is attached.
>
> This is the first time I change anything other than documentation in any
> eclass so I would very, very much appreciate your comments. In
> particular, do we really need a revision bump? I initially decided to
> err on the side of caution because I would rather not have the SRC_URI
> change break all the app-dicts/sword-* modules, that said Portage
> usually (always?) queries Gentoo mirrors before attempting to fetch
> directly from SRC_URI so maybe it is harmless after all?
>

Please use git-send-email, so that we can reply in context without
jumping through hoops.

-- 
Best regards,
Michał Górny