| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Mike Frysinger wrote: |
| 5 |
> On Tuesday 25 September 2007, Bo �rsted Andresen wrote: |
| 6 |
>> On Tuesday 25 September 2007 12:47:35 Marijn Schouten (hkBst) wrote: |
| 7 |
>>>>> # "make test" does something weird so default src_test() in |
| 8 |
>>>>> /usr/lib/portage/bin/ebuild.sh fails the following test # elif emake |
| 9 |
>>>>> -j1 test -n &> /dev/null; then |
| 10 |
>>>>> # so copy straight from default src_test() all the stuff which |
| 11 |
>>>>> depends on that test passing src_test() { |
| 12 |
>>>>> vecho ">>> Test phase [test]: ${CATEGORY}/${PF}" |
| 13 |
>>>>> if ! emake -j1 test; then |
| 14 |
>>>>> hasq test $FEATURES && die "Make test failed. See above for |
| 15 |
>>>>> details." hasq test $FEATURES || eerror "Make test failed. See above |
| 16 |
>>>>> for details." fi |
| 17 |
>>>>> } |
| 18 |
>>>> I'm a bit confused about what's going on here. Isn't src_test() only |
| 19 |
>>>> supposed to run when 'test' is in FEATURES? |
| 20 |
>>> I'm not sure, but as the comment says, I copied this straight from |
| 21 |
>>> /usr/lib/portage/bin/ebuild.sh and it goes: |
| 22 |
>> [SNIP] |
| 23 |
>> |
| 24 |
>> Some of that code is unreachable since src_test is never called when test |
| 25 |
>> is not in FEATURES. Also there is some dispute as to whether testing the |
| 26 |
>> FEATURES variable at all is permitted in ebuilds (bug #174335). In either |
| 27 |
>> case it's not needed here. if `emake -j1 test -n` really fails for some |
| 28 |
>> reason even though `emake -j1 test` generally works your src_test should |
| 29 |
>> just be: |
| 30 |
>> |
| 31 |
>> src_test() { |
| 32 |
>> emake -j1 test || die "Make test failed" |
| 33 |
>> } |
| 34 |
> |
| 35 |
> why is src_test() defined at all ... the default src_test will execute `emake |
| 36 |
> check` if possible and then try `emake test` |
| 37 |
> -mike |
| 38 |
|
| 39 |
I cannot reproduce the failure that caused me to copy part of the code from |
| 40 |
usr/lib/portage/bin/ebuild.sh so I've removed src_test from this bigloo ebuild |
| 41 |
and rely now on the default. |
| 42 |
|
| 43 |
Who's gonna fix usr/lib/portage/bin/ebuild.sh? |
| 44 |
|
| 45 |
Marijn |
| 46 |
|
| 47 |
- -- |
| 48 |
Marijn Schouten (hkBst), Gentoo Lisp project |
| 49 |
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode |
| 50 |
-----BEGIN PGP SIGNATURE----- |
| 51 |
Version: GnuPG v2.0.7 (GNU/Linux) |
| 52 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org |
| 53 |
|
| 54 |
iD8DBQFG+nRpp/VmCx0OL2wRAgszAKCibdBHe5WoBZLprKTSxZ02wrKc0wCeNUwq |
| 55 |
9snyDtGguXvZoCkF5p1F5tQ= |
| 56 |
=yLpT |
| 57 |
-----END PGP SIGNATURE----- |
| 58 |
-- |
| 59 |
gentoo-dev@g.o mailing list |
Archives