| 1 |
On wto, 2017-08-15 at 06:55 +0200, tomjbe@g.o wrote: |
| 2 |
> Quoting Rich Freeman (2017-08-15 00:29:19) |
| 3 |
> > On Mon, Aug 14, 2017 at 5:55 PM, Michał Górny <mgorny@g.o> wrote: |
| 4 |
> > > On pon, 2017-08-14 at 21:58 +0200, Thomas Beierlein wrote: |
| 5 |
> > > > |
| 6 |
> > > > * 'bacula-clientonly' becomes 'clientonly' |
| 7 |
> > > |
| 8 |
> > > This is still negative logic in disguise. clientonly = noserver. |
| 9 |
> |
| 10 |
> True. See below for discussion. |
| 11 |
> > > |
| 12 |
> > > > * 'bacula-nodir' will be replaced by 'director' but with inverted logic |
| 13 |
> > > > * 'bacula-nosd' will be replaced by 'storage-daemon' (also inverted). |
| 14 |
> > > > |
| 15 |
> > > > 'director' and 'storage-daemon' will be active by default resulting in an |
| 16 |
> > > > installation with backup director and storage daemon enabled. |
| 17 |
> > > > |
| 18 |
> > |
| 19 |
> > ++ |
| 20 |
> > |
| 21 |
> > I guess to make it a bit more explicit, would it make sense to have 3 flags: |
| 22 |
> > |
| 23 |
> > client - install the client (or consider calling it file-daemon instead) |
| 24 |
> > director - install the director |
| 25 |
> > storage-daemon - install the storage daemon |
| 26 |
> > |
| 27 |
> |
| 28 |
> That would be best, but it is not supported by their (autoconf based) build |
| 29 |
> system (and would require a complete rewrite of it). The actual USE flags |
| 30 |
> mostly mirrors the switches from the configure script. You can not set them as |
| 31 |
> you like, they are not orthogonal E.g. the file deamon (client) will be |
| 32 |
> installed unconditionally. |
| 33 |
> |
| 34 |
> The configure script itself is very brittle atm and needs an urgent overhaul. |
| 35 |
> Discussion with upstream goes a long way, but they do not want to change it |
| 36 |
> because of the need to retest it on very different systems. No good situation. |
| 37 |
> |
| 38 |
> A possible idea may be to drop the 'no/client' flag completely. If neither |
| 39 |
> 'director' nor 'storage-daemon' is active all that is left would be the |
| 40 |
> file daemon. |
| 41 |
> What do you think? |
| 42 |
|
| 43 |
WFM. If the flag doesn't do anything except for disabling the two other |
| 44 |
flags, then there's no place for such a flag. |
| 45 |
|
| 46 |
> |
| 47 |
> The downside of that idea is that we diverge from baculas documentation which |
| 48 |
> explicitly state that there is a 'clientonly' install. |
| 49 |
> |
| 50 |
|
| 51 |
Upstream install documentation is not relevant to Gentoo. The flag |
| 52 |
descriptions in metadata.xml are. |
| 53 |
|
| 54 |
-- |
| 55 |
Best regards, |
| 56 |
Michał Górny |
Archives