Gentoo Archives: gentoo-dev

From: "Haelwenn (lanodan) Monnier" <contact@×××××××××.me>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/4] llvm.eclass: Update examples for newer LLVM versions
Date: Tue, 30 Apr 2019 16:57:42
Message-Id: 20190430165732.GB18520@cloudsdale.the-delta.net.eu.org
In Reply to: [gentoo-dev] [PATCH 2/4] llvm.eclass: Update examples for newer LLVM versions by "Michał Górny"
1 [2019-04-30 07:38:56+0200] Michał Górny:
2 > Signed-off-by: Michał Górny <mgorny@g.o>
3 > ---
4 > eclass/llvm.eclass | 12 +++++++-----
5 > 1 file changed, 7 insertions(+), 5 deletions(-)
6 >
7 > diff --git a/eclass/llvm.eclass b/eclass/llvm.eclass
8 > index 618a924bbb87..e4052a6400c0 100644
9 > --- a/eclass/llvm.eclass
10 > +++ b/eclass/llvm.eclass
11 > @@ -17,18 +17,19 @@
12 > # a proper dependency string yourself to guarantee that appropriate
13 > # version of LLVM is installed.
14 > #
15 > -# Example use for a package supporting LLVM 3.8 to 5:
16 > +# Example use for a package supporting LLVM 5 to 7:
17 > # @CODE
18 > # inherit cmake-utils llvm
19 > #
20 > # RDEPEND="
21 > -# <sys-devel/llvm-6:=
22 > +# <sys-devel/llvm-8:=
23 > # || (
24 > +# sys-devel/llvm:7
25 > +# sys-devel/llvm:6
26 > # sys-devel/llvm:5
27 > -# sys-devel/llvm:4
28 > -# >=sys-devel/llvm-3.8:0
29 > # )
30 > # "
31 > +# DEPEND=${RDEPEND}
32 > #
33 > # LLVM_MAX_SLOT=5
34
35 Shouldn’t LLVM_MAX_SLOT be set to 7 as well?
36
37 > #
38 > @@ -46,8 +47,9 @@
39 > # # note: do not use := on both clang and llvm, it can match different
40 > # # slots then. clang pulls llvm in, so we can skip the latter.
41 > # RDEPEND="
42 > -# >=sys-devel/clang-4:=[llvm_targets_AMDGPU(+)]
43 > +# >=sys-devel/clang-6:=[llvm_targets_AMDGPU(+)]
44 > # "
45 > +# DEPEND=${RDEPEND}
46 > #
47 > # llvm_check_deps() {
48 > # has_version "sys-devel/clang:${LLVM_SLOT}[llvm_targets_AMDGPU(+)]"
49 > --
50 > 2.21.0
51 >
52 >

Replies