Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: Brian Harring <ferringb@×××××.com>
Cc: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [PATCH] eutils: Warn on built_with_use usage
Date: Mon, 17 Sep 2012 02:11:43
Message-Id: 201209162210.48503.vapier@gentoo.org
In Reply to: [gentoo-dev] [PATCH] eutils: Warn on built_with_use usage by Brian Harring
1 On Sunday 16 September 2012 03:51:04 Brian Harring wrote:
2 > + if ! has $EAPI 0 1 2 3; then
3 > + eqawarn "built_with_use should not be used in $EAPI; use USE deps."
4 > + elif has $EAPI 2 3; then
5 > + if [[ $hidden == yes ]] || $missing_was_set; then
6 > + eqawarn "built_with_use in EAPI=$EAPI without --missing or --
7 hidden
8 > usage, should use USE deps instead." + else
9 > + eqawarn "built_with_use should not be used; upgrade to EAPI=4
10 instead"
11 > + fi
12 > + fi
13
14 i'd do:
15 case ${EAPI:-0} in
16 # No support in these EAPIs, so don't warn.
17 0|1) ;;
18 # Maybe warn as some functionality exist.
19 2|3) [[...]] && eqawarn "..." ;;
20 # Assume EAPI=4 or newer where all functionality exists.
21 *) eqawarn "..." ;;
22 esac
23 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
[gentoo-dev] Re: [PATCH] eutils: Warn on built_with_use usage Brian Harring <ferringb@×××××.com>