Gentoo Archives: gentoo-dev

From: Jeremy Olexa <darkside@g.o>
To: gentoo-dev@l.g.o, keri@g.o
Cc: gentoo-commits@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/pedro: metadata.xml ChangeLog pedro-1.5.ebuild
Date: Sat, 03 Jul 2010 00:33:37
Message-Id: 526367928f28e98f8af1f607ceafd9bc@localhost
On Fri,  2 Jul 2010 23:59:34 +0000 (UTC), "Keri Harris (keri)"
<keri@g.o> wrote:
> Index: pedro-1.5.ebuild > =================================================================== > # Copyright 1999-2010 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: /var/cvsroot/gentoo-x86/net-misc/pedro/pedro-1.5.ebuild,v > 1.1 2010/07/02 23:59:34 keri Exp $ > > EAPI=1 > > inherit eutils
Why do you need to inherit eutils? Nothing uses it.
> > DESCRIPTION="Pedro is a subscription/notification communications system" > HOMEPAGE="http://www.itee.uq.edu.au/~pjr/HomePages/PedroHome.html" > SRC_URI="http://www.itee.uq.edu.au/~pjr/HomePages/PedroFiles/${P}.tgz > doc? ( mirror://gentoo/${PN}-manual-${PV}.tar.gz )" > > LICENSE="GPL-2" > SLOT="0" > KEYWORDS="~amd64 ~ppc ~sparc ~x86" > IUSE="doc examples" > > DEPEND="dev-libs/glib:2" > > S="${WORKDIR}"/${P} > > src_unpack() { > unpack ${A} > cd "${S}" > }
This is the default src_unpack and can be dropped.
> > src_compile() { > econf || die "econf failed" > emake || die "emake failed" > }
econf() doesn't need "|| die" but furthermore, this is the default src_compile and can be dropped.
> > src_install() { > emake DESTDIR="${D}" install || die "emake install failed" > > dodoc AUTHORS README > > if use doc ; then > dodoc "${WORKDIR}"/${PN}.pdf > fi > > if use examples ; then > insinto /usr/share/doc/${PF}/examples > doins src/examples/*.{c,tcl} > doins src/java_api/*.java > doins src/python_api/*.py > fi > }
Those are just cosmetic fixes above, but this should be fixed: * QA Notice: Files built without respecting LDFLAGS have been detected * Please include the following list of files in your report: * /usr/bin/pedro * /usr/bin/ptick Thanks, Jeremy

Replies