| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 01/25/2014 05:12 AM, Markos Chandras wrote: |
| 5 |
> On 01/23/2014 04:48 PM, Michał Górny wrote: |
| 6 |
>> Dnia 2014-01-23, o godz. 11:36:06 Chris Reffett |
| 7 |
>> <creffett@g.o> napisał(a): |
| 8 |
>> |
| 9 |
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 |
| 10 |
>>> |
| 11 |
>>> On 01/23/2014 11:28 AM, Michał Górny wrote: |
| 12 |
>>>> Dnia 2014-01-23, o godz. 11:24:41 Chris Reffett |
| 13 |
>>>> <creffett@g.o> napisał(a): |
| 14 |
>>>> |
| 15 |
>>>>> After some discussion on good ways to communicate optional |
| 16 |
>>>>> dependencies to users, I was shown the optfeature() |
| 17 |
>>>>> function in net-misc/netctl. Gentoo contributor Andrew |
| 18 |
>>>>> Hamilton and I came up with a cleaned up and expanded |
| 19 |
>>>>> version of it, and I would like to add it to eutils.eclass |
| 20 |
>>>>> to provide a standard way of notifying users of optional |
| 21 |
>>>>> dependencies. The patch to eutils.eclass is attached. |
| 22 |
>>>> |
| 23 |
>>>> This was discussed already: |
| 24 |
>>>> |
| 25 |
>>>> http://thread.gmane.org/gmane.linux.gentoo.devel/72162 |
| 26 |
>>>> |
| 27 |
>>> First of all, this is a short patch for a function, not a full |
| 28 |
>>> eclass. |
| 29 |
>> |
| 30 |
>> Ah, sorry, this changes *a lot*. Let's start the bikeshed again |
| 31 |
>> then, whatever. |
| 32 |
>> |
| 33 |
> I haven't looked at the implementation, but I wonder if we need a |
| 34 |
> function for such trivial stuff. Most maintainers deal with this |
| 35 |
> problem using pkg_postinst() einfo/elog messages. Why do we need a |
| 36 |
> dedicated function for that? Just for consistency reasons...? |
| 37 |
> |
| 38 |
Consistency, and because it removes the need for a bunch of "if |
| 39 |
has_version" lines, instead only displaying if you don't satisfy the |
| 40 |
deps (and supports both "and" and "or" groupings for packages |
| 41 |
satisfying the dep). This also stems from a complaint I've seen a lot |
| 42 |
about how optional dep messages should only display if the requisite |
| 43 |
package isn't installed, this makes that job a little simpler. But |
| 44 |
mostly consistency, this gives us one nice function that we can |
| 45 |
standardize on. |
| 46 |
|
| 47 |
Chris Reffett |
| 48 |
-----BEGIN PGP SIGNATURE----- |
| 49 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 50 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 51 |
|
| 52 |
iKYEARECAGYFAlLjt6NfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl |
| 53 |
bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC |
| 54 |
Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1SAZACgqLjfMMmvPNa/6Nwxzlpm5sde |
| 55 |
kwQAniZMjvFkQ7H/1+wpYnDjyezplMud |
| 56 |
=6E+E |
| 57 |
-----END PGP SIGNATURE----- |
Archives