| 1 |
>>>>> On Mon, 09 Dec 2019, Jaco Kroon wrote: |
| 2 |
|
| 3 |
> Acked-by: Jaco Kroon <jaco@××××××.za> |
| 4 |
|
| 5 |
OK, I can add this. |
| 6 |
|
| 7 |
>> + if [[ ${EROOT:-/} != / ]] ; then |
| 8 |
>> return 0 |
| 9 |
>> fi |
| 10 |
|
| 11 |
> I don't use spaces in path names ... but what happens here if ROOT or |
| 12 |
> EPREFIX (and by implication EROOT) contains a space? |
| 13 |
|
| 14 |
No problem here, the test would still succeed and return 0. (But I |
| 15 |
predict that EROOT containing spaces will cause a lot of trouble |
| 16 |
elsewhere. :) |
| 17 |
|
| 18 |
> What about just checking "${EROOT}/boot" instead? |
| 19 |
|
| 20 |
For what, existence? There may well be a "boot" directory present under |
| 21 |
EROOT. (And we could check ${EROOT}/etc/fstab, but I don't think we |
| 22 |
should open that can of worms. There's no reliable way to guess the |
| 23 |
user's exact configuration for non-trivial ROOT.) |
| 24 |
|
| 25 |
Ulrich |
Archives