| 1 |
> On 9 Apr 2021, at 22:10, Joerg Bornkessel <hd_brummy@g.o> wrote: |
| 2 |
> |
| 3 |
> https://bugs.gentoo.org/show_bug.cgi?id=778815 |
| 4 |
> |
| 5 |
> pkgcheck, gives an error like this |
| 6 |
> VariableScope: vdr-plugin-2: variable 'WORKDIR' used in 'vdr-plugin-2_pkg_setup', line 371 |
| 7 |
> |
| 8 |
|
| 9 |
Hi, thanks for looking into this! |
| 10 |
|
| 11 |
> inserted patch will fix this issues |
| 12 |
|
| 13 |
Could you make the change in a git checkout and then use ‘git format-patch’ and then |
| 14 |
git send-email to send it here? |
| 15 |
|
| 16 |
> |
| 17 |
> <snip> |
| 18 |
> --- vdr-plugin-2.eclass 2020-02-23 17:39:40.000000000 +0100 |
| 19 |
> +++ vdr-plugin-2_QA-fixed.eclass 2021-04-06 23:27:37.358477036 +0200 |
| 20 |
> @@ -368,7 +368,7 @@ |
| 21 |
> VDR_INCLUDE_DIR="/usr/include/vdr" |
| 22 |
> DVB_INCLUDE_DIR="/usr/include" |
| 23 |
> |
| 24 |
> - TMP_LOCALE_DIR="${WORKDIR}/tmp-locale" |
| 25 |
> + TMP_LOCALE_DIR="${T}/tmp-locale" |
| 26 |
> |
| 27 |
> LOCDIR=$(pkg-config --variable=locdir vdr) |
| 28 |
> </snap> |
| 29 |
> |
| 30 |
|
| 31 |
This looks fine as-is, although you may want to take the opportunity |
| 32 |
to do some other clean ups, like replacing pkg-config with |
| 33 |
$(tc-getPKG_CONFIG) to respect the ${PKG_CONFIG} variable |
| 34 |
for e.g. cross-compilation. |
| 35 |
|
| 36 |
We should add pkg-config to BDEPEND in EAPI 7 if it’s needed too. |
| 37 |
|
| 38 |
It looks like there are some missing || dies on e.g. sed and other |
| 39 |
external commands too which we could fix. |
| 40 |
|
| 41 |
> i did several tests on my setup, it works like expected. |
| 42 |
> please review, thanks... |
| 43 |
> |
| 44 |
> -- |
| 45 |
> Joerg Bornkessel <hd_brummy@g.o> |
| 46 |
> GnuPG Key: 0x93EB5F4DAA5832A1 |
| 47 |
> Fingerprint: 0E0A A1EE 1DF4 41D7 A3F5 21C2 93EB 5F4D AA58 32A1 |
| 48 |
> |
Archives