Gentoo Archives: gentoo-dev

From: Thomas Bracht Laumann Jespersen <t@×××××××.xyz>
To: gentoo-dev@l.g.o
Cc: Hans de Graaff <graaff@g.o>
Subject: Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig
Date: Fri, 20 May 2022 07:28:22
Message-Id: 20220520072804.ucf7magsmagartbb@sofaking
In Reply to: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig by Hans de Graaff
1 > this is easy to mis in the ebuild. Handle this in the eclass instead
2
3 small typo: mis -> miss
4
5 > +if [ ${#RUBY_FAKEGEM_EXTENSIONS[@]} -ge 1 ]; then
6
7 shouldn't it be [[ ]] and not [ ] ? Also, just a suggestion, do "-gt 0" instead
8 of "-ge 1"
9
10 -- Thomas

Replies