Re: [gentoo-dev] RFC: Update bitcoin eclass to default to knots

[Mathy Vanvoorden]

2017-03-06 15:53 GMT+01:00 Anthony G. Basile <basile@××××××××××.net>:

> Bitcoin Knots includes a number of enhancements users may find useful. I
> think  it would be a good idea to make it the default for Bitcoin
> ebuilds (net-p2p/bitcoin-qt, net-p2p/bitcoind, and dev-util/bitcoin-tx).
>

As a Bitcoin user I personally don't feel too happy with my experience
changing without me changing USE-flags. I'm not against changing the name
of the USE-flag, just against changing the default behavior and applying a
bunch of patches that Core might or might not support.

If you compare this to the kernel would it not make more sense to create
something like bitcoin-knots (vanilla-sources vs gentoo-sources)?

- This does NOT enable the historically-controversial spamfilte
> BITCOIN_POLICY.
>

That doesn't really matter, the default behavior changes, the application
is not what Bitcoin devs expect, especially when reporting bugs upstream.

- Knots has since 0.12 (over a year old) included a clearly different
> splash   screen and branding, so even if the user somehow misses the USE
> flag change   and explicit src_prepare warning, it is clear upfront at
> startup and runtime   that they are running Knots rather than Core.
>

This fortifies my point about the name change. If it is a separate product,
package it like that. Time will tell if the users choose to adopt the
-knots version.


> A bug tracker for this has been open for 2 months with no objections:
>     https://bugs.gentoo.org/show_bug.cgi?id=604520
>

That's not really a reference as I don't think anyone (at least not me) is
in the habit of checking all potential bugs for every package they have
installed on their system. If you would have posted this on -dev 2 months
ago without any objections things would be different.

br,
Mathy