Gentoo Archives: gentoo-dev

From: David Stanek <dstanek@×××××××.com>
To: Eric Olinger <EvvL@××××××××××.net>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Release: metadata.xml python module
Date: Mon, 28 Jun 2004 23:57:37
Message-Id: 20040628235033.GB17877@goliath
In Reply to: [gentoo-dev] Release: metadata.xml python module by Eric Olinger
1 Looks good and even more important it works. I have never seen that
2 dictionary based approach to knowing where you are in the tag
3 hierarchy. I do have a couple of suggestions to enhance readability.
4 (Bear with me, I like lines under 80 characters)
5
6 1. instead of
7 if __tags_.has_key(...) and __tags_[...] == "Yes":
8 this makes that line much easier to read
9 if __tags_.get(...) == "Yes"
10 2. using -1 as an index into an array gets the last element and is
11 much easier to read than array[len(array)-1]
12
13 Eric I have emailed you separately my changes, if you like em keep
14 em free of charge :-D If not then feel free to delete the email.
15
16 --
17 David Stanek (roninds)
18 dstanek@×××××××.com
19 http://www.dstanek.com

Replies

Subject Author
Re: [gentoo-dev] Release: metadata.xml python module Eric Olinger <EvvL@××××××××××.net>