| 1 |
On 05/21/2012 02:01 AM, Jonathan Callen wrote: |
| 2 |
> On 05/20/2012 07:49 PM, hasufell wrote: |
| 3 |
>> On 05/21/2012 01:36 AM, Alexis Ballier wrote: |
| 4 |
>>> On Mon, 21 May 2012 01:24:13 +0200 hasufell |
| 5 |
>>> <hasufell@g.o> wrote: |
| 6 |
>>> |
| 7 |
>>>> I want support for installing icons into the appropriate |
| 8 |
>>>> directories which are under /usr/share/icons/... and not |
| 9 |
>>>> just pixmaps. |
| 10 |
>>>> |
| 11 |
>>>> proposal attached + diff |
| 12 |
>>>> |
| 13 |
>>>> This should not break existing ebuilds. Tested a bit and |
| 14 |
>>>> open for review now. |
| 15 |
>>> |
| 16 |
>>> maybe i missed something but cant you just make doicon a |
| 17 |
>>> newicon wrapper and remove all that code duplication ? |
| 18 |
>>> |
| 19 |
> |
| 20 |
>> I don't see how. "doicon" supports installing multiple icons |
| 21 |
>> with one command, as well as directories. That does not work for |
| 22 |
>> "newicon". |
| 23 |
> |
| 24 |
> |
| 25 |
> |
| 26 |
> Normally, new* is a wrapper for do* that does something like: |
| 27 |
> |
| 28 |
> newfoo() { # argument checking omitted... cp -P "${1}" "${T}/${2}" |
| 29 |
> dofoo "${T}/${2}" } |
| 30 |
> |
| 31 |
> |
| 32 |
|
| 33 |
That does not use "newins" like the old function. Why would I want to |
| 34 |
change that? |
Archives