Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Allow variable refs in HOMEPAGE
Date: Fri, 04 Aug 2017 06:50:45
Message-Id: 1501829424.2012.3.camel@gentoo.org
In Reply to: Re: [gentoo-dev] Allow variable refs in HOMEPAGE by Michael Orlitzky
1 On czw, 2017-08-03 at 23:24 -0400, Michael Orlitzky wrote:
2 > On 08/03/2017 06:33 PM, Ulrich Mueller wrote:
3 > > > > > > > On Thu, 3 Aug 2017, Michael Orlitzky wrote:
4 > > > The developer handbook that I just said didn't mention variables in
5 > > > HOMEPAGE at all.
6 > >
7 > > It did, even back in 2004:
8 > > https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/xml/htdocs/proj/en/devrel/handbook/hb-guide-ebuild.xml?hideattic=0&revision=1.10&view=markup#l534
9 > >
10 >
11 > You got me, but now we can see where that text came from and it proves
12 > my original point that the last line was added as an afterthought and
13 > isn't any sort of policy:
14 >
15 > https://bugs.gentoo.org/show_bug.cgi?id=73272
16 >
17 > Which is good, because it's a silly rule, and hundreds of ebuilds in the
18 > tree wisely ignore it.
19
20 There's a significant difference between being unaware of a policy
21 and intentionally disrespecting it. Now that you've been made aware, we
22 can start pursuing it.
23
24 > Why single out HOMEPAGE? I might like to copy/paste the econf arguments,
25 > so should we forbid the use of $(use_enable foo) and force everyone to
26 > use "if" statements? Of course not; if you need the value of HOMEPAGE
27 > (or anything else), there are more intelligent ways to get it than
28 > opening up the ebuild, digging though the source code, and manually
29 > performing the variable substitutions that the programming language is
30 > there to do for us.
31 >
32 > Use the metadata, use eix, use emerge --search, write an echo statement
33 > into the ebuild, whatever. Don't handicap everyone so that you can treat
34 > their source code as part of your user interface.
35
36 Why is it fine for you to handicap everyone else for your personal
37 laziness? As it's been told more than once, you write ebuild *once*,
38 people read it *multiple times*.
39
40 When reviewing pull requests, submitted ebuilds etc. I *have to* verify
41 this stuff. I don't have time to copy everything to a local tree just to
42 get some random tool process it correctly and give me the value I need.
43 Just to figure out there's some trivial issue that blocks any further
44 progress, and I will have to do this again, and again, and again.
45 Because someone thinks it's cool to save 5 bytes in variable references.
46
47 --
48 Best regards,
49 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Allow variable refs in HOMEPAGE Michael Orlitzky <mjo@g.o>