Gentoo Archives: gentoo-dev

From: "Robin H. Johnson" <robbat2@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: gentoo-x86/net-misc/aggregate: aggregate-1.6.ebuild
Date: Sat, 30 Oct 2010 09:26:47
Message-Id: robbat2-20101030T092149-703636005Z@orbis-terrarum.net
In Reply to: [gentoo-dev] Re: gentoo-x86/net-misc/aggregate: aggregate-1.6.ebuild by Fabian Groffen
1 On Thu, Oct 28, 2010 at 11:30:55AM +0200, Fabian Groffen wrote:
2 > On 28-10-2010 09:25:23 +0000, Samuli Suominen wrote:
3 > > ssuominen 10/10/28 09:25:23
4 > >
5 > > Modified: aggregate-1.6.ebuild
6 > > Log:
7 > > qa
8 >
9 > I think it would be good practice if you would give a summary of
10 > what type of QA you applied, even though for you it may be obvious.
11 > I just see lots of unnecessary changes that are apparently considered to
12 > be justified by "QA".
13 As the maintainer of the package in question, I'd like to ask:
14 If you're changing a package I maintain, put SOMETHING in the Changelog.
15
16 Secondly, I'm wondering if this should have been a revbump: your
17 addition of tc-export could have changed the results.
18
19 --
20 Robin Hugh Johnson
21 Gentoo Linux: Developer, Trustee & Infrastructure Lead
22 E-Mail : robbat2@g.o
23 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85