| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Harald van D?k wrote: |
| 5 |
> The only flags that are actually removed are the flags that are invalid |
| 6 |
> _by themselves_. There are cases where flags are valid because of other |
| 7 |
> flags, such as anything following -X*. |
| 8 |
> |
| 9 |
> Two other problems I see with the code: |
| 10 |
> CFLAGS=${CFLAGS//bad-flag} is in the ebuild quiz, if I recall correctly. |
| 11 |
> It's broken because it also removes valid flags that happen to contain |
| 12 |
> bad-flag as a substring. |
| 13 |
> Locale isn't forced to C, which means gcc may not spit out 'unrecognized |
| 14 |
> option' at all even for invalid flags. |
| 15 |
|
| 16 |
There is a new version at http://dev.gentoo.org/~chutzpah/profile.bashrc that |
| 17 |
should fix all these possible problems. Thanks for pointing them out, let me |
| 18 |
know if you see anything else. |
| 19 |
-----BEGIN PGP SIGNATURE----- |
| 20 |
Version: GnuPG v1.4.2.2 (GNU/Linux) |
| 21 |
|
| 22 |
iD8DBQFEP+A9Wt/XSf2CZdkRArP3AKCZZQd7V7oBTsQnxzBMDXX9VGnxpQCbBm4l |
| 23 |
vr359Gk/O0NPPk2/2CnUPw8= |
| 24 |
=3HQj |
| 25 |
-----END PGP SIGNATURE----- |
| 26 |
-- |
| 27 |
gentoo-dev@g.o mailing list |
Archives