Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Alexandre Rostovtsev <tetromino@g.o>
Cc: gentoo-dev@l.g.o, Jason Zaman <jason@×××××××××.com>
Subject: Re: [gentoo-dev] net-misc/strongswan USE_EXPAND
Date: Tue, 23 Jun 2015 06:06:05
Message-Id: 20150623080535.0b7afb56@pomiot
In Reply to: Re: [gentoo-dev] net-misc/strongswan USE_EXPAND by Alexandre Rostovtsev
1 Dnia 2015-06-23, o godz. 01:48:58
2 Alexandre Rostovtsev <tetromino@g.o> napisał(a):
3
4 > On Tue, 2015-06-23 at 07:06 +0200, Michał Górny wrote:
5 > > Dnia 2015-06-23, o godz. 01:23:13
6 > > Jason Zaman <jason@×××××××××.com> napisał(a):
7 > >
8 > > > On Mon, Jun 22, 2015 at 10:55:45PM +0200, Michał Górny wrote:
9 > > > > Dnia 2015-06-22, o godz. 16:38:30
10 > > > > Jason Zaman <perfinion@g.o> napisał(a):
11 > > > >
12 > > > > > Hi all,
13 > > > > >
14 > > > > > I want to add STRONGSWAN_PLUGINS to USE_EXPAND. This is related
15 > > > > > to bug
16 > > > > > https://bugs.gentoo.org/show_bug.cgi?id=504942
17 > > > > > "net-misc/strongswan missing USE flags for plugins"
18 > > > > >
19 > > > > > Patrick said to fix it myself, the ebuilds with the plugins
20 > > > > > have
21 > > > > > been in the tree for a fair while now and only the USE_EXPAND
22 > > > > > is
23 > > > > > missing.
24 > > > > >
25 > > > > > If there are no objections, I will commit the following patch
26 > > > > > on friday:
27 > > > >
28 > > > > USE_EXPAND is global by its nature. USE flags used by a single
29 > > > > package
30 > > > > are not appropriate for making global.
31 > > >
32 > > > Since when? There are so many things in USE_EXPAND that are only
33 > > > for a
34 > > > single package.
35 > >
36 > > Not sure when. But the policies about USE flags were in the devmanual
37 > > long before I came here.
38 > >
39 > > > APACHE2_MODULES, NGINX_MODULES_HTTP, COLLECTD_PLUGINS, QEMU_*, etc.
40 > > > Easily half of the things in USE_EXPAND are for only a single
41 > > > package.
42 > >
43 > > Past screwups don't justify future screwups.
44 >
45 > I don't see it as a screwup personally.
46 >
47 > It is often useful to have different namespaces for the few general
48 > flags that control a package's general features and the >9000 flags
49 > that enable/disable >9000 highly specific plugins.
50 >
51 > And if violation of the rules is useful, perhaps the rules are wrong?
52
53 Then perhaps you go and fix the rules instead of ignoring them?
54
55 But please also remember to provide the ability to describe those flags
56 per-package rather than globally, like they are done now. Would be good
57 to also avoid declaring them globally, like having >50 groups listed in
58 USE_EXPAND.
59
60 When you're done with that, and get all package managers to support it
61 in a reasonably long stable version, then we can discuss about changing
62 the rules.
63
64 --
65 Best regards,
66 Michał Górny
67 <http://dev.gentoo.org/~mgorny/>

Replies

Subject Author
Re: [gentoo-dev] net-misc/strongswan USE_EXPAND Jason Zaman <perfinion@g.o>