[gentoo-dev] Re: [RFC] Font eclass EAPI update and design

[Peter Volkov]

В Пнд, 01/02/2010 в 11:35 +0100, Tomáš Chvátal пишет:
> As I was reworking the x-modular-r2 eclass I found out that most of the
> slowdowns for fonts were produced in fonts eclass.

Exactly what slowdowns are you talking about? I've reviewed all changes
and I don't see any noticeable performance improvements anywhere. Or
what do you mean?

> I would like to ask you to review the changes and spot anything that
> might slipped my sight.

1.
-FONT_SUFFIX=${FONT_SUFFIX:-}
+: ${FONT_SUFFIX:=}

What are the benefits of this change? Personally I prefer first syntax
more since it's more evident and does not need to run empty command :

2.
if has X ${IUSE//+} && use X ; then

I'm not sure. With this change should we update all packages depending
on font.eclass to have X in IUSE?

3.
If you dropped

if has_version '>=media-libs/fontconfig-2.4'; then

then >=media-libs/fontconfig-2.4 should be in DEPEND.

4.
+       [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation
failed" ; }

This should be non fatal, until somebody installs all packages that
inherit font.eclass and assures us that nothing broke with this change.

-- 
Peter.
h