| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Wulf C. Krueger wrote: |
| 5 |
| We would welcome any comments, especially if accompanied by patches ;) |
| 6 |
| and, of course, your kind approval to commit it. :-) |
| 7 |
|
| 8 |
Hi, |
| 9 |
|
| 10 |
Checked only briefly, it's late :) but I miss a comment in the header |
| 11 |
that you need EAPI=1 in ebuild to use this eclass (slot deps...), |
| 12 |
perhaps a check that it's really set? |
| 13 |
|
| 14 |
|
| 15 |
And some small things I noticed: |
| 16 |
DEPEND="${DEPEND} - first time you define DEPEND it's empty, no? Not |
| 17 |
carried from eclass to eclass (as it used to be when the portage |
| 18 |
behavior was broken IIRC) but separate in each eclass. |
| 19 |
|
| 20 |
kde4-meta.eclass says # @ECLASS: kde4-functions.eclass |
| 21 |
|
| 22 |
The (non-existing atm :) Copyright could use 2008 already :) |
| 23 |
|
| 24 |
VB |
| 25 |
-----BEGIN PGP SIGNATURE----- |
| 26 |
Version: GnuPG v2.0.8 (GNU/Linux) |
| 27 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org |
| 28 |
|
| 29 |
iEYEARECAAYFAkeIB5wACgkQtbrAj05h3oTtbQCeM+V7yKKG5uOLablx357W8QId |
| 30 |
2KAAn1bTJvdZ8wM+38QgWBnHwGO0cbB0 |
| 31 |
=rVAg |
| 32 |
-----END PGP SIGNATURE----- |
| 33 |
-- |
| 34 |
gentoo-dev@l.g.o mailing list |
Archives