Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: Gentoo GNU Emacs project <gnu-emacs@g.o>, Sam James <sam@g.o>
Subject: [gentoo-dev] [PATCH] elisp-common.eclass: fix for Emacs 29 (explicitly require autoload)
Date: Thu, 18 Aug 2022 19:18:46
Message-Id: 20220818191820.3731062-1-sam@gentoo.org
1 Emacs 29's NEWS says: "The autoload.el library is now obsolete."
2
3 We should therefore explicitly 'require it in order to have the
4 eclass machinery work.
5
6 Fix build failures with e.g. exec-path-from-shell, flycheck:
7 ```
8 * Generating autoload file for GNU Emacs ...
9
10 Error: void-function (batch-update-autoloads)
11 debug-early-backtrace()
12 debug-early(error (void-function batch-update-autoloads))
13 batch-update-autoloads()
14 command-line-1(("--eval" "(setq make-backup-files nil)" "--eval" "(setq generated-autoload-file (expand-file-name \"exec-path-from-shell-autoloads.el\"))" "-f" "batch-update-autoloads" "."))
15 command-line()
16 normal-top-level()
17 Symbol’s function definition is void: batch-update-autoloads
18 * elisp-make-autoload-file: batch-update-autoloads failed
19 [ !! ]
20 * ERROR: app-emacs/exec-path-from-shell-1.12::gentoo failed (compile phase):
21 * (no error message)
22 ```
23
24 See https://www.mail-archive.com/freebsd-pkg-fallout@×××××××.org/msg1982134.html
25 and https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-08/msg01259.html.
26
27 Thanks-to: John Turner <jturner.usa+gentoo@×××××.com>
28 Signed-off-by: Sam James <sam@g.o>
29 ---
30 eclass/elisp-common.eclass | 1 +
31 1 file changed, 1 insertion(+)
32
33 diff --git a/eclass/elisp-common.eclass b/eclass/elisp-common.eclass
34 index 47c8132192ca..2715c26c91a8 100644
35 --- a/eclass/elisp-common.eclass
36 +++ b/eclass/elisp-common.eclass
37 @@ -329,6 +329,7 @@ elisp-make-autoload-file() {
38 EOF
39
40 ${EMACS} ${EMACSFLAGS} \
41 + --eval "(require 'autoload)" \
42 --eval "(setq make-backup-files nil)" \
43 --eval "(setq generated-autoload-file (expand-file-name \"${f}\"))" \
44 -f batch-update-autoloads "${@-.}"
45 --
46 2.37.2

Replies