Re: [gentoo-dev] [PATCH 2/2] php-ext-pecl-r3.eclass: new revision supporting EAPI=6.

[Michael Orlitzky]

I'll start with the easy one first. A new version is attached.


On 06/01/2016 01:53 PM, Michał Górny wrote:
>> +
>> +[[ -z ${MY_PV} ]] && MY_PV=${PV}
>
> Is MY_PV part of the API? If yes, document it, and preferably rename
> into something more collision-proof. If not, you shouldn't be doing
> [[ -z ...
>

Uhhhh I don't think so. It's probably leaking through from some ebuilds,
but I just documented that you're going to have to fix that on the wiki
page and made the eclass ignore it.

As part of a greater campaign for sanity, I'm also requiring that the
PHP_EXT_PECL_FILENAME variable contain a file name. Previously we had
something like SRC_URI="...${PHP_EXT_PECL_FILENAME}-${MY_PV}.tgz".


>> +PECL_PKG="${PHP_EXT_PECL_PKG}"
>> +MY_PV="${MY_PV/_/}"
>> +PECL_PKG_V="${PECL_PKG}-${MY_PV}"
>
> If exported as part of the API, please document it. Otherwise, remember
> to unset it after use.
>

After the MY_PV fix, I still had one undocumented variable laying around
in global scope. I mangled the name for safety, and unset it after use.


>> +
>> +# @FUNCTION: php-ext-pecl-r3_src_compile
>> +# @DESCRIPTION:
>> +# Compile a standard PECL package. The process is the same as for any
>> +# standalone PHP extension, so we delegate to php-ext-source-r3.eclass.
>> +php-ext-pecl-r3_src_compile() {
>> +	php-ext-source-r3_src_compile
>> +}
>
> Any reason to re-export it?
>

Because -r2 did =P

It's fixed.



>> +
>> +	if has examples ${IUSE} && use examples ; then
>
> This is prohibited. Use in_iuse.
>

Thanks, fixed.



>> +		NO_INTERACTION="yes" emake test || \
>> +			die "emake test failed for slot ${slot}"
>
> emake dies in this EAPI, so your die will never be called.
>

This too, thanks.