Gentoo Archives: gentoo-dev

From: yac <yac@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] New eclass - twisted-r1
Date: Thu, 11 Jul 2013 16:44:35
Message-Id: 20130711184412.58949ad7@gentoo.org
In Reply to: Re: [gentoo-dev] New eclass - twisted-r1 by "Michał Górny"
1 On Wed, 10 Jul 2013 22:25:50 +0200
2 Michał Górny <mgorny@g.o> wrote:
3 > > python_test() {
4 > > # TODO: this seems to be used only in dev-python/twisted-*
5 > > packages as # dev-python/twisted-13.0.0 have it's own src_test
6 > > if [[ "${CATEGORY}/${PN}" != "dev-python/twisted"* ]]; then
7 > > die "${FUNCNAME}() can be used only in
8 > > dev-python/twisted* packages" fi
9 > >
10 > > local sitedir="${EPREFIX}$(python_get_sitedir)"
11 > >
12 > > # Copy modules of other Twisted packages from site-packages
13 > > directory to temporary directory. mkdir -p "${T}/${sitedir}"
14 > > cp -R "${ROOT}${sitedir}/twisted" "${T}/${sitedir}" || die
15 > > "Copying of modules of other Twisted packages failed with
16 > > $(python_get_implementation) $(python_get_version)" rm -fr
17 > > "${T}/${sitedir}/${PN/-//}"
18 >
19 > Awful and ugly. Try to find a way to run the tests without this
20 > hackery.
21
22 What are you referring to?
23
24 For the "${CATEGORY}/${PN}" match. All the non-twisted packages are
25 overriding src_test but it's probably be gonna cleaner to rename the
26 python_test to twisted-r1_twisted_test and call it explicitly for the
27 twisted packages.
28
29 As for the Copy modules, I'm afraid that's inevitable.

Attachments

File name MIME type
signature.asc application/pgp-signature