1 |
I tested your proposed modification, it works far better than mine. |
2 |
|
3 |
I was just wrong in the beginning, my problem was lines starting with a |
4 |
space (for allignment purpose) and my patch break the others tasks on |
5 |
lines not starting with a space. |
6 |
|
7 |
Now dcron work for lines starting or not with a space or tabs or... |
8 |
|
9 |
For your information dcron2.7 is the standard cron for the Gentoo |
10 |
Linux distribution. http://www.gentoo.org |
11 |
|
12 |
> |
13 |
> :I just fired gdb to find the source of this problem and found the source |
14 |
> :of the problem being at line 178 of database.c |
15 |
> : |
16 |
> :was: buf[strlen(ptr)-1] = 0; |
17 |
> :is now on my system: buf[strlen(ptr)] = 0; |
18 |
> : |
19 |
> :This line was chopping 2 char at the end of the line the last one of the |
20 |
> :command and the newline. You have to remove one char but indexing |
21 |
> :starts at 0 and strlen give the number of char. |
22 |
> : |
23 |
> :I'm new to patch submission, howto ? |
24 |
> : |
25 |
> :Regards |
26 |
> |
27 |
> Well, I do not know who is maintaining the linux version of dcron. |
28 |
> I maintain my master source but I don't think the linux sites are |
29 |
> picking it up. |
30 |
> |
31 |
> In regards to this bug, I think the problem is that it should be |
32 |
> 'ptr[strlen(ptr)-1] = 0' rather then 'buf[strlen(ptr)-1] = 0'. |
33 |
> That is, it is trying to remove the newline at the end of the |
34 |
> buffer. The bug occurs if you have spaces at the front of the line. |
35 |
> |
36 |
> Please try 'ptr[strlen(ptr)-1] = 0' and see if that solves your |
37 |
> problem. |
38 |
> |
39 |
> -Matt |
40 |
> |
41 |
> _______________________________________________ |
42 |
> gentoo-dev mailing list |
43 |
> gentoo-dev@g.o |
44 |
> http://lists.gentoo.org/mailman/listinfo/gentoo-dev |
45 |
> |
46 |
|
47 |
----------------------------------------------- |
48 |
Christian HOFFMANN <christian.hoffmann@××××.fr> |