Gentoo Archives: gentoo-dev

From: Joonas Niilola <juippis@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/3] savedconfig.eclass: Always quote filename in output
Date: Sun, 04 Aug 2019 06:33:12
Message-Id: b1a58976-b7e0-dae6-dfc8-f620ce830cf4@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 2/3] savedconfig.eclass: Always quote filename in output by Mike Gilbert
1 On 8/3/19 11:49 PM, Mike Gilbert wrote:
2 > On Sat, Aug 3, 2019 at 12:21 PM Ulrich Mueller <ulm@g.o> wrote:
3 >>>>>>> On Sat, 03 Aug 2019, Thomas Deutschmann wrote:
4 >>> + ewarn "provide a configuration file in ${PORTAGE_CONFIGROOT%/}/etc/portage/savedconfig/${CATEGORY}/${PN}"
5 >> Long line.
6 > How would you shorten it? Splitting it across 2 lines in the middle of
7 > the string just makes it less readable.
8 >
9 I think he was referring to line length limit by devmanual,
10
11 https://devmanual.gentoo.org/ebuild-writing/messages/index.html
12
13
14 Anyway:
15
16   ewarn "provide a configuration file in:"
17   ewarn "${PORTAGE_CONFIGROOT%/}/etc/portage/savedconfig/${CATEGORY}/${PN}"
18
19 doesn't IMHO make it less-readable.
20
21
22 -- Joonas 'juippis' Niilola

Attachments

File name MIME type
signature.asc application/pgp-signature