Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | "Michał Górny" <mgorny@g.o> | ||
| Cc: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages | ||
| Date: | Wed, 13 Jan 2021 20:53:18 | ||
| Message-Id: | umtxcr230@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages by "Michał Górny" |
||
| 1 | >>>>> On Wed, 13 Jan 2021, Michał Górny wrote: |
| 2 | |
| 3 | >> Looks like this loop can run only once, so it is redundant? |
| 4 | |
| 5 | > It's the old C trick for convenient error handling. |
| 6 | |
| 7 | Newfangled contraptions. What's wrong with goto? :) |
| 8 | |
| 9 | > Do you have any other suggestion? I suppose we could use a nested |
| 10 | > function if you think that's nicer. |
| 11 | |
| 12 | No, it's fine. Maybe an explanatory comment would be helpful, because I |
| 13 | think that code isn't obvious. |
| 14 | |
| 15 | Ulrich |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages | "Michał Górny" <mgorny@g.o> |